alloc: update memory allocation pointer type from NonZeroUsize to NonNull<u8> in ByteAllocator trait #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please fix CI. |
…Null<u8> in ByteAllocator trait
|
After using |
…nge to NonNull<u8>
equation314
reviewed
Aug 23, 2023
api/arceos_api/src/imp/mem.rs
Outdated
| @@ -4,13 +4,13 @@ cfg_alloc! { | |||
|
|
|||
| pub fn ax_alloc(layout: Layout) -> Option<NonNull<u8>> { | |||
| if let Ok(vaddr) = axalloc::global_allocator().alloc(layout) { | |||
| Some(unsafe { NonNull::new_unchecked(vaddr.get() as _) }) | |||
| Some(vaddr) | |||
There was a problem hiding this comment.
These lines can be simplified to axalloc::global_allocator().alloc(layout).ok()
equation314
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the memory allocation pointer type from NonZeroUsize to NonNull in the ByteAllocator trait of the Rust open-source operating system project.
Motivation/Improvement Reason:
This PR modifies the ByteAllocator trait and its implementations to use NonNull as the memory allocation pointer type. The changes include updating the return type of the alloc method to AllocResult<NonNull>, and the parameter type of the dealloc method to NonNull